Matthias Clasen [Wed, 18 Jun 2014 02:06:08 +0000 (22:06 -0400)]
Drop the builtin icon cache
We don't need it anymore, now that the non-standard stock icons
are using resources.
Matthias Clasen [Wed, 18 Jun 2014 01:32:50 +0000 (21:32 -0400)]
Add non-standard stock icons as resources
This will allow us to remove the builtin icon cache in the future
while keeping the deprecated stock icons working.
Matthias Clasen [Tue, 17 Jun 2014 23:17:36 +0000 (19:17 -0400)]
Drop all standard icons from the builtin icontheme
We're going to require a complete icon theme, and we have
a test that checks for all the icons we use, so there is
no need to include all these fallback icons.
Benjamin Otte [Thu, 19 Jun 2014 18:00:16 +0000 (20:00 +0200)]
stylecontext: Deprecate regions
Regions are done in a very non-css way. They don't fit the DOM in that
they don't integrate into the CSS tree and they have very weird matching
behavior in selectors.
So I'm deprecating them now. GtkNotebook and GtkTreeview will continue
to use them and as long as they do, we can't remove the code for it.
But once those are ported it might be safe to remove the code as it will
clean up lots of places in the code by quite a bit.
Benjamin Otte [Thu, 19 Jun 2014 17:46:52 +0000 (19:46 +0200)]
stylecontext: Remove long outdated docs
The part about transition animations doesn't apply since 3.8.
Jasper St. Pierre [Thu, 19 Jun 2014 19:04:09 +0000 (15:04 -0400)]
gdkwindow-wayland: Destroy the wl_surface too when hiding a window
wl_surfaces can't switch roles, so destroying the xdg_surface but not
the wl_surface means that we could get an error when trying to re-map
the surface.
We could fix this by not destroying the xdg resource and only do it at
finalization time, but it's just as easy to just create a new wl_surface.
Jasper St. Pierre [Thu, 19 Jun 2014 19:10:01 +0000 (15:10 -0400)]
gdkwindow-wayland: Destroy the xdg roles before the wl_surface
Since the xdg roles are a special case of the surface, some compositors
like Weston destroy them automatically when the wl_surface is destroyed.
Thus, we need to destroy these first.
Jasper St. Pierre [Thu, 19 Jun 2014 18:55:04 +0000 (14:55 -0400)]
gdkwindow-wayland: Add a forgotten ref
Jasper St. Pierre [Thu, 19 Jun 2014 18:34:22 +0000 (14:34 -0400)]
gdkwindow-wayland: Another slight rearrange
Jasper St. Pierre [Thu, 19 Jun 2014 18:33:35 +0000 (14:33 -0400)]
gdkwindow-wayland: Pair a ref with its owner
Jasper St. Pierre [Thu, 19 Jun 2014 18:31:23 +0000 (14:31 -0400)]
gdkwindow-wayland: Don't post CONFIGURE events for the same size
The Wayland compositor is completely allowed to send us configure
events for the same size, and this validly happens if we're changing
states. Fizzle these out.
Matthias Clasen [Thu, 19 Jun 2014 17:51:25 +0000 (13:51 -0400)]
GtkTreeView: Remove a no-longer-valid optimization
The rubberband rendering code was assuming that we just have
a 1-pixel border and the rest of the rubberband is uniform.
That is not a safe assumption to make with css-styled
rubberbands, so remove it.
Matthias Clasen [Thu, 19 Jun 2014 17:50:28 +0000 (13:50 -0400)]
GtkIconView: Remove a no-longer-valid optimization
The rubberband rendering code was assuming that we just have
a 1-pixel border and the rest of the rubberband is uniform.
That is not a safe assumption to make with css-styled
rubberbands, so remove it.
Matthias Clasen [Thu, 19 Jun 2014 16:54:31 +0000 (12:54 -0400)]
Install the new icontheme test files
Lapo Calamandrei [Thu, 19 Jun 2014 17:11:02 +0000 (19:11 +0200)]
Adwaita: fix rubberband selection
Jasper St. Pierre [Thu, 19 Jun 2014 15:13:17 +0000 (11:13 -0400)]
Update Makefile.am for one more gitignore rule
Jasper St. Pierre [Thu, 19 Jun 2014 14:16:22 +0000 (10:16 -0400)]
Update git.mk
Matthias Clasen [Wed, 18 Jun 2014 22:21:51 +0000 (18:21 -0400)]
GtkIconTheme: Fix svg loading with FORCE_SIZE
Paradoxically, we were loading svgs at the nominal size when
FORCE_SIZE is specified, while scaling them exactly when it
isn't.
../build/win32/vs10/gtk.vcxproj
Matthias Clasen [Wed, 18 Jun 2014 22:19:39 +0000 (18:19 -0400)]
Add more icon theme tests
This test checks various directory size behaviours, with and
without the FORCE_SIZE flag.
Jakub Steiner [Wed, 18 Jun 2014 17:40:11 +0000 (19:40 +0200)]
Adwaita: hover state for horizontal spinbuttons
Nikita Churaev [Wed, 18 Jun 2014 16:09:43 +0000 (20:09 +0400)]
New window shadows
https://bugzilla.gnome.org/show_bug.cgi?id=731866
Lapo Calamandrei [Wed, 18 Jun 2014 17:38:14 +0000 (19:38 +0200)]
Adwaita: highligh not hilight...
Lapo Calamandrei [Wed, 18 Jun 2014 17:29:33 +0000 (19:29 +0200)]
Adwaita: remove wildcard for image effect
-gtk-image-effect: hilight now is set for .button:hover
Lapo Calamandrei [Wed, 18 Jun 2014 16:13:38 +0000 (18:13 +0200)]
Adwaita: calendar fixes
Matthias Clasen [Wed, 18 Jun 2014 15:49:00 +0000 (11:49 -0400)]
GtkHeaderBar: Don't forget to show the subtitle
https://bugzilla.gnome.org/show_bug.cgi?id=731790
Jakub Steiner [Wed, 18 Jun 2014 14:36:00 +0000 (16:36 +0200)]
Adwaita: flatten buttons slightly.
- gets rid of the specialcase for dark too.
Lapo Calamandrei [Wed, 18 Jun 2014 14:07:59 +0000 (16:07 +0200)]
Adwaita: more links styling
Lars Uebernickel [Wed, 18 Jun 2014 11:25:02 +0000 (13:25 +0200)]
themes: use .popover class instead of GtkPopover
https://bugzilla.gnome.org/show_bug.cgi?id=731834
Lars Uebernickel [Wed, 18 Jun 2014 11:13:30 +0000 (13:13 +0200)]
gtkpopover: set background and popover css classes
https://bugzilla.gnome.org/show_bug.cgi?id=731834
Lapo Calamandrei [Wed, 18 Jun 2014 11:26:35 +0000 (13:26 +0200)]
Adwaita: remove bg from insensitive backdrop spinbutton buttons
Lapo Calamandrei [Wed, 18 Jun 2014 11:16:21 +0000 (13:16 +0200)]
Adwaita: vertical spinbuttons inhert in backdrop state
Jakub Steiner [Wed, 18 Jun 2014 10:16:55 +0000 (12:16 +0200)]
Adwaita: actionbars' padding
Lapo Calamandrei [Wed, 18 Jun 2014 10:08:04 +0000 (12:08 +0200)]
Adwaita: reorderable tabs correctly styled for every notebook layout
Lapo Calamandrei [Wed, 18 Jun 2014 08:21:13 +0000 (10:21 +0200)]
Adwaita: set outline-color on selected items
Lapo Calamandrei [Wed, 18 Jun 2014 08:11:11 +0000 (10:11 +0200)]
Adwaita: checks and radios text focus ring fix.
Lapo Calamandrei [Wed, 18 Jun 2014 08:01:24 +0000 (10:01 +0200)]
Adwaita: minor fixes.
Lapo Calamandrei [Wed, 18 Jun 2014 07:52:29 +0000 (09:52 +0200)]
Adwaita: .scrollbars-junction
Yosef Or Boczko [Wed, 18 Jun 2014 00:12:40 +0000 (03:12 +0300)]
Updated Hebrew properties translation
Matthias Clasen [Tue, 17 Jun 2014 20:26:42 +0000 (16:26 -0400)]
Include image data in the builtin icon theme cache
When we switched the default for gtk-update-icon-cache to
not include image data, we should have thought about the
builtin icons. For them, we rely on image data being included.
This made the notify test fail in gnome-continuous, where we
build from git and always regenerate the builtin cache.
Matthias Clasen [Tue, 17 Jun 2014 18:38:18 +0000 (14:38 -0400)]
Add a test for builtin icons
We want to get rid of these, but as long as we still have them,
make sure they work.
Alexander Larsson [Tue, 17 Jun 2014 16:05:22 +0000 (18:05 +0200)]
icon theme: Fix crash for builtin icons
This pushes the initialization of is_svg to an earlier point
when the GtkIconInfo is created. This is needed because an icon
info doesn't necessarily always have a filename that we can later
extract the suffix from. For instance, builtin icons have NULL
filename.
https://bugzilla.gnome.org/show_bug.cgi?id=721895
Jakub Steiner [Tue, 17 Jun 2014 13:55:58 +0000 (15:55 +0200)]
Adwaita: selection mode buttons to have borders and fill
Jakub Steiner [Tue, 17 Jun 2014 13:41:59 +0000 (15:41 +0200)]
Adwaita: symbolic checkboxes for selection mode.
Jakub Steiner [Tue, 17 Jun 2014 13:39:45 +0000 (15:39 +0200)]
Adwaita: make bash actually call sass
Chun-wei Fan [Tue, 17 Jun 2014 09:53:36 +0000 (17:53 +0800)]
Visual Studio Builds: "Install" the Stock Icons
Copy the icons in stock_icons accordingly, so that the built-in icons can
be found by GTK, as it seems that not all of them are built into
gtkbuiltincache.h.
Benjamin Otte [Mon, 16 Jun 2014 20:20:08 +0000 (22:20 +0200)]
testsuite: Add test for latest commit
Benjamin Otte [Mon, 16 Jun 2014 20:13:07 +0000 (22:13 +0200)]
cssprovider: Names starting with -gtk- aren't style props
We want to have the "-gtk-" prefix for our custom CSS properties. But
we also want to parse names starting with a "-" as style properties.
So make sure that "-gtk-" is treated like a normal property and we emit
errors when somebody uses it wrong.
This is to catch errors with people typing
-gtk-iconsource: none;
instead of the correct
-gtk-icon-source: none;
Matthias Clasen [Mon, 16 Jun 2014 21:31:56 +0000 (17:31 -0400)]
Revert "gtkbin: replace internal api"
This reverts commit
0f4751c08e22a4f45d58e2368e4ae82df407d330.
This causes warnings from the notebook and combobox code.
Piotr Drąg [Mon, 16 Jun 2014 20:12:39 +0000 (22:12 +0200)]
Updated POTFILES.skip
Ryan Lortie [Mon, 16 Jun 2014 18:26:21 +0000 (14:26 -0400)]
menu binding: emit submenu close after activate
We want to make sure that the submenu action is changed back to FALSE
_after_ the menu item has been activated. This prevents the menu
teardown handler from deleting the menu item before it can be activated.
Unfortunately, GtkMenuShell emits "hide" before the item activation.
This is probably done to prevent the application from doing things like
showing dialogs when the menu is still holding the grab.
In the case where we are doing an activate, set a boolean flag on each
of the open menus (following the parent stack) indicating that we'll be
emitting another signal soon (selection done). If that flag is set, we
defer the setting of the submenu action until we receive the second
signal.
https://bugzilla.gnome.org/show_bug.cgi?id=729820
Jasper St. Pierre [Mon, 16 Jun 2014 17:08:48 +0000 (13:08 -0400)]
Makefile: Add a few more cleanfile / ignore rules
Jasper St. Pierre [Mon, 16 Jun 2014 17:04:30 +0000 (13:04 -0400)]
Makefile: Add gtk.gresource.xml to gitignore
Lapo Calamandrei [Mon, 16 Jun 2014 17:57:56 +0000 (19:57 +0200)]
Adwaita: list-row styling
Benjamin Otte [Fri, 13 Jun 2014 19:19:35 +0000 (21:19 +0200)]
testsuite: Remove a test
That test is not working anymore by design since commit
57c4f01e.
It was introduced pre-3.0.0 in commit
12d6b588 and the feature was never
utilized. So it seems safe to just remove the test.
Benjamin Otte [Thu, 12 Jun 2014 12:39:12 +0000 (14:39 +0200)]
colorswatch: handle clip for box-shadow
Lapo Calamandrei [Mon, 16 Jun 2014 15:14:20 +0000 (17:14 +0200)]
Adwaita: fix a typo
Lapo Calamandrei [Mon, 16 Jun 2014 15:12:03 +0000 (17:12 +0200)]
Adwaita: GtkPaned separator invisible border shrinking
Lapo Calamandrei [Mon, 16 Jun 2014 15:07:27 +0000 (17:07 +0200)]
Adwaita: fix column-header backdrop state
Jasper St. Pierre [Mon, 16 Jun 2014 14:41:35 +0000 (10:41 -0400)]
gtkicontheme: Fix a missing case where we forget to set is_svg
When duplicating the icon_info, we forgot to set is_svg. This meant that
any application that used gtk_icon_info_load_icon_async wouldn't have
is_svg set properly.
This fixes blurry icons in the gnome-shell app picker.
Jasper St. Pierre [Mon, 16 Jun 2014 14:42:22 +0000 (10:42 -0400)]
util: Add missing git.mk include
Lapo Calamandrei [Mon, 16 Jun 2014 14:45:24 +0000 (16:45 +0200)]
Adwaita: column headers visual simplification
Chun-wei Fan [Mon, 16 Jun 2014 04:07:04 +0000 (12:07 +0800)]
GtkInspector: Use Adwaita by Default on Windows Too
As we are using Adwaita by default on all platforms, do the same for
GtkInspector, to be consistent with the rest of GTK+.
Paolo Borelli [Sun, 15 Jun 2014 16:27:52 +0000 (18:27 +0200)]
TextView: render the background of border windows
Set the .top, .left, etc css classes and render the background
of the border windows.
Change the reftest implementation accordingly.
Paolo Borelli [Sun, 15 Jun 2014 16:11:15 +0000 (18:11 +0200)]
Add a TextView reftests checking border-windows
TextView border windows are internal windows used to draw on the gutter
of the textview (e.g. line numbers). The test uses the gmodule hook to
programmatically draw on the border-windows at each side of the textview
and compares the result with 3x3 grid of labels.
Paolo Borelli [Sat, 14 Jun 2014 20:51:13 +0000 (22:51 +0200)]
TextView margin reftest
add a reftest that checks GtkTextView text margin property comparing
with the normal margin added to the widget (they are the same when there
is nothing drawn in the gutter like line numbers etc).
Paolo Borelli [Sun, 15 Jun 2014 10:05:40 +0000 (12:05 +0200)]
Dist recently added reftests
Kalev Lember [Sun, 15 Jun 2014 09:24:39 +0000 (11:24 +0200)]
Fix another typo
Matthias Clasen [Sun, 15 Jun 2014 08:15:32 +0000 (04:15 -0400)]
Fix a typo
Matthias Clasen [Sun, 15 Jun 2014 02:52:57 +0000 (22:52 -0400)]
Install all icons for installed tests
Otherwise the icontheme test fails in continuous.
Matthias Clasen [Sun, 15 Jun 2014 01:43:14 +0000 (21:43 -0400)]
Revert "Fixes GtkMenuTrackerItem visible flag reference"
This reverts commit
ceed0ee7032810476e1563884a7cb04c8fad8ce8.
Will Greenberg [Mon, 9 Jun 2014 22:22:24 +0000 (15:22 -0700)]
Fixes GtkMenuTrackerItem visible flag reference
Previously GtkMenuTracker tried to access "gtk_menu_tracker_item_get_is_visible",
but the correct getter is "_gtk_menu_tracker_item_is_visible". This commit
corrects this reference
https://bugzilla.gnome.org/show_bug.cgi?id=731430
Matthias Clasen [Sat, 14 Jun 2014 23:30:17 +0000 (19:30 -0400)]
gtk-update-icon-cache: Add an --include-image-data option
Now that we don't include the image data by default anymore,
lets add an option that does it.
Matthias Clasen [Sat, 14 Jun 2014 22:54:24 +0000 (18:54 -0400)]
gtkicontheme: Don't query CONTENT_TYPE to determine svg
We already know based on the suffix of the filename.
https://bugzilla.gnome.org/show_bug.cgi?id=721895
Jasper St. Pierre [Fri, 10 Jan 2014 17:14:41 +0000 (12:14 -0500)]
updateiconcache: Don't include image data by default anymore
Since large images are in the icon cache, and apps don't tend to use that
many icons anymore, simply don't include image data and instead make apps
load files from disk. Additionally, since they're stored in GdkPixbuf data,
that means that we have to first convert them either to a cairo_surface_t,
which requires converting pixel data to be premulitplied, or an OpenGL
texture, which requires a whole GPU upload anyway.
So, even with the icon cache, the goal of icons through zero-copy, mmap()'d
data from disk just isn't doable with the icon cache format we have. The
icon cache on my disk is nearing 100MB, since we include a bunch of
high-resolution application icons, that I doubt would be used by apps at all.
Removing this inefficient pixel data makes memory usage for all applications
go down, with no speed loss.
The icon cache also, however, has an index of what icons are in each folder,
which prevents a readdir() and allows GTK+ to know what icon is where without
having to do a bunch of stat(); calls. Keeping this data is good for GTK+,
so we should still keep the index.
It doesn't make sense to remove any code for mapping pixel data from the icon
cache. There's a plan in the works to have a symbolic icon cache that does
pixel math on 16x16 icons to prevent slow SVG rendering. 16x16 pixels are
fairly small, and such images are flat colors, which should compress easily,
so the icon cache would be worthwhile here. So let's keep the code around
in preparation for that case.
https://bugzilla.gnome.org/show_bug.cgi?id=721895
Paolo Borelli [Thu, 12 Jun 2014 19:12:18 +0000 (21:12 +0200)]
notebook: set tab position style class on the main frame
We want to have .top etc also on the notebook frame, not only on
the header frame.
The patch includes a reftest by Benjamin.
Matthias Clasen [Sat, 14 Jun 2014 15:19:12 +0000 (11:19 -0400)]
GtkIconTheme: Don't treat svg icons specially
This changes makes svg icons go through the same scale calculation
code as png icons. As a consequence, an svg that is put into the
32x32 directory will actually be loaded at size 32, even if it
gets requested at a bigger size. This will let us avoid giant
spinners.
https://bugzilla.gnome.org/show_bug.cgi?id=731658
Matthias Clasen [Sat, 14 Jun 2014 19:06:57 +0000 (15:06 -0400)]
Add more icontheme tests
This test is focused on svgs, and how we scale them when
loading.
Lapo Calamandrei [Sat, 14 Jun 2014 17:06:26 +0000 (19:06 +0200)]
Adwaita: try to make scrollbars near paned separator usable.
Piotr Drąg [Sat, 14 Jun 2014 14:46:06 +0000 (16:46 +0200)]
Remove duplicate lines in Azerbaijani translation headers
Lapo Calamandrei [Sat, 14 Jun 2014 13:37:36 +0000 (15:37 +0200)]
Adwaita: comment added
Lapo Calamandrei [Sat, 14 Jun 2014 13:31:05 +0000 (15:31 +0200)]
Adwaita: fix GtkScale outline offset and radius
Lapo Calamandrei [Sat, 14 Jun 2014 12:49:20 +0000 (14:49 +0200)]
Adwaita: Gtkscale
- added slider assets for scales with marks
- experimental touch friendly fine-tune mode, grow the trough istead
of shrinking the slider
Rico Tzschichholz [Sat, 14 Jun 2014 11:13:29 +0000 (13:13 +0200)]
Adwaita: drop references to render-borders.sh/borders.txt
They were dropped with
82b12328987425a2c7342e259c9147df3787bdb9
Lapo Calamandrei [Sat, 14 Jun 2014 09:30:22 +0000 (11:30 +0200)]
Adwaita: noticiable scale slider active state for the dark variant
Lapo Calamandrei [Sat, 14 Jun 2014 09:01:31 +0000 (11:01 +0200)]
Adwaita: include missing assets
Lapo Calamandrei [Sat, 14 Jun 2014 09:00:33 +0000 (11:00 +0200)]
Adwaita: darker base color for the dark variant
Lapo Calamandrei [Sat, 14 Jun 2014 08:48:28 +0000 (10:48 +0200)]
Adwaita: dark var backdrop insensitive fixes
Consistent backdrop insensitive state for dark variant GtkScale and GtkSwitch
Lapo Calamandrei [Sat, 14 Jun 2014 08:19:15 +0000 (10:19 +0200)]
Adwaita: GtkScale
slider :hover state added
Lapo Calamandrei [Sat, 14 Jun 2014 07:00:21 +0000 (09:00 +0200)]
Adwaita: sidebar separator and selected item backdrop fix
Lapo Calamandrei [Sat, 14 Jun 2014 06:45:55 +0000 (08:45 +0200)]
Adwaita: added a missing border to GtkFileChooser
Lapo Calamandrei [Sat, 14 Jun 2014 06:42:12 +0000 (08:42 +0200)]
Adwaita: better tab close button
Lapo Calamandrei [Sat, 14 Jun 2014 06:31:36 +0000 (08:31 +0200)]
Adwaita: remove old cruft not used anymore
Lapo Calamandrei [Sat, 14 Jun 2014 06:29:11 +0000 (08:29 +0200)]
check and radio assets refresh
Stefan Sauer [Fri, 13 Jun 2014 17:04:39 +0000 (19:04 +0200)]
scrolledwindow: update GtkPolicyType docs
The policy is not determining the visibility of the scrollbars anymore, but the
how the size is to be computed to achive the selected visibility.
Stefan Sauer [Wed, 4 Jun 2014 19:23:01 +0000 (21:23 +0200)]
gtkbin: replace internal api
Matthias Clasen [Sat, 14 Jun 2014 04:15:09 +0000 (00:15 -0400)]
inspector: Use Adwaita as default theme
Matthias Clasen [Fri, 13 Jun 2014 20:49:59 +0000 (16:49 -0400)]
Use Adwaita on Windows too
Having the same, usable, default appearance acroll platforms
trumps having a more-or-less working native theme. The default
will be Adwaita on all platforms. The native ms-windows theme
is of course still available.
Matthias Clasen [Fri, 13 Jun 2014 18:42:38 +0000 (14:42 -0400)]
Adwaita: bring back the extra indirection
Without this, we are missing the 'Adwaita' component in the
path when resolving relative resources, and none of the assets
are found.
Matthias Clasen [Fri, 13 Jun 2014 18:16:37 +0000 (14:16 -0400)]
Try to fix the continuous build
Making gtk.gresource.xml generated was causing a problem for
srcdir!=builddir builds from git. Builds from tarballs are
not affected, because the tarball contains the generated file.
Matthias Clasen [Fri, 13 Jun 2014 18:03:52 +0000 (14:03 -0400)]
Add some EXEEXT decorations back
Might fix
https://bugzilla.gnome.org/show_bug.cgi?id=731602